From 44be3cb3196e39bebdf13fd0c097d83524a3ebe9 Mon Sep 17 00:00:00 2001 From: Josh Salway Date: Wed, 22 Apr 2026 16:56:21 +1000 Subject: [PATCH] Drop tests/Feature/QueueSafetyTest.php The test only asserted property values and method_exists. The diff itself shows the property values; the test added zero confidence beyond reading the diff. Heimdall is an app, not a package; its existing tests are HTTP feature tests against user behavior, not class-property assertions. Removing this file keeps the PR aligned with the existing test conventions. --- tests/Feature/QueueSafetyTest.php | 39 ------------------------------- 1 file changed, 39 deletions(-) delete mode 100644 tests/Feature/QueueSafetyTest.php diff --git a/tests/Feature/QueueSafetyTest.php b/tests/Feature/QueueSafetyTest.php deleted file mode 100644 index c4fc32db9..000000000 --- a/tests/Feature/QueueSafetyTest.php +++ /dev/null @@ -1,39 +0,0 @@ -assertSame(3, $job->tries); - $this->assertSame([30, 60, 120], $job->backoff); - $this->assertSame(60, $job->timeout); - $this->assertSame(3600, $job->uniqueFor); - } - - /** @test */ - public function processApps_has_bounded_retry_properties(): void - { - $job = new ProcessApps(); - - $this->assertSame(3, $job->tries); - $this->assertSame([30, 60, 120], $job->backoff); - $this->assertSame(60, $job->timeout); - $this->assertSame(3600, $job->uniqueFor); - } - - /** @test */ - public function both_jobs_expose_a_failed_method(): void - { - $this->assertTrue(method_exists(UpdateApps::class, 'failed')); - $this->assertTrue(method_exists(ProcessApps::class, 'failed')); - } -}