mirror of
https://github.com/linuxserver/Heimdall.git
synced 2026-08-07 07:16:13 +00:00
KodeStar
f547ae42bb
get_stats/{id} fataled when the item id was missing and 500'd whenever an
enhanced app's livestats() threw - a broken or updated remote app definition
(e.g. Komga) took the whole request down, and the frontend then stopped
refreshing that tile entirely.
getStats now returns valid JSON (200) with an inactive/empty payload when the
item is missing, has no class, references a stale class, or throws, logging
the failure for diagnosis. The successful path is unchanged and returns the
livestats output verbatim.
Resolves #1558
88 lines
2.1 KiB
PHP
88 lines
2.1 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature;
|
|
|
|
use App\Item;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* Fixture app whose live stats rendering throws, mirroring the Komga
|
|
* failure from issue #1558 (broken remote blade / upstream API error).
|
|
*/
|
|
class ThrowingStatApp
|
|
{
|
|
public $config;
|
|
|
|
public function livestats()
|
|
{
|
|
throw new \Exception('boom');
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Fixture app whose live stats rendering succeeds and returns the JSON
|
|
* string the frontend expects.
|
|
*/
|
|
class HappyStatApp
|
|
{
|
|
public $config;
|
|
|
|
public function livestats()
|
|
{
|
|
return json_encode(['status' => 'active', 'html' => '<b>ok</b>']);
|
|
}
|
|
}
|
|
|
|
class GetStatsTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_missing_item_id_does_not_500(): void
|
|
{
|
|
$response = $this->get('get_stats/999999');
|
|
|
|
$response->assertStatus(200);
|
|
$response->assertJson(['status' => 'inactive', 'html' => '']);
|
|
}
|
|
|
|
public function test_throwing_app_degrades_gracefully(): void
|
|
{
|
|
$item = Item::factory()->create([
|
|
'class' => ThrowingStatApp::class,
|
|
]);
|
|
|
|
$response = $this->get('get_stats/'.$item->id);
|
|
|
|
$response->assertStatus(200);
|
|
$response->assertJson(['status' => 'inactive', 'html' => '']);
|
|
}
|
|
|
|
public function test_item_with_no_class_degrades_gracefully(): void
|
|
{
|
|
$item = Item::factory()->create([
|
|
'class' => null,
|
|
]);
|
|
|
|
$response = $this->get('get_stats/'.$item->id);
|
|
|
|
$response->assertStatus(200);
|
|
$response->assertJson(['status' => 'inactive', 'html' => '']);
|
|
}
|
|
|
|
public function test_happy_path_returns_livestats_output_verbatim(): void
|
|
{
|
|
$item = Item::factory()->create([
|
|
'class' => HappyStatApp::class,
|
|
]);
|
|
|
|
$expected = json_encode(['status' => 'active', 'html' => '<b>ok</b>']);
|
|
|
|
$response = $this->get('get_stats/'.$item->id);
|
|
|
|
$response->assertStatus(200);
|
|
$this->assertSame($expected, $response->getContent());
|
|
$response->assertJson(['status' => 'active', 'html' => '<b>ok</b>']);
|
|
}
|
|
}
|