mirror of
https://github.com/linuxserver/Heimdall.git
synced 2026-08-07 07:16:13 +00:00
Josh Salway
5be7a65677
Most failures for these jobs are GitHub API rate-limit responses; retries inside the same window do not help, so one attempt is enough and $backoff has nothing to pace. $timeout would clip the intentionally throttled handle() loop (sleep(1) per app) below realistic workloads. Heavy users with 60+ apps would lose updates mid-cycle. The original code left $timeout unset, and `UpdateApps` is dispatched via `dispatchAfterResponse()` which doesn't go through `queue:work` at all (the queue $timeout is irrelevant in that path). Letting the operator's worker config govern is more honest. $uniqueFor reduced to 600 (10 min) since with $tries=1 + worker-governed timeout there is no long retry chain to outlive. Lock self-heals 10 minutes after a crashed worker.
76 lines
2.0 KiB
PHP
76 lines
2.0 KiB
PHP
<?php
|
|
|
|
namespace App\Jobs;
|
|
|
|
use App\Application;
|
|
use GuzzleHttp\Exception\GuzzleException;
|
|
use Illuminate\Bus\Queueable;
|
|
use Illuminate\Contracts\Queue\ShouldBeUnique;
|
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
|
use Illuminate\Foundation\Bus\Dispatchable;
|
|
use Illuminate\Queue\InteractsWithQueue;
|
|
use Illuminate\Queue\SerializesModels;
|
|
use Illuminate\Support\Facades\Cache;
|
|
use Illuminate\Support\Facades\Log;
|
|
use Throwable;
|
|
|
|
class UpdateApps implements ShouldQueue, ShouldBeUnique
|
|
{
|
|
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
|
|
|
/**
|
|
* Most failures here are GitHub rate-limit responses; retries inside the
|
|
* same window do not help, so a single attempt is enough. The throttle
|
|
* loop in handle() means the job is intentionally long-running, so we
|
|
* leave $timeout unset and let the operator's worker config govern.
|
|
*/
|
|
public int $tries = 1;
|
|
|
|
/**
|
|
* Expire the ShouldBeUnique lock after 10 minutes so a crashed worker
|
|
* does not permanently block future UpdateApps dispatches.
|
|
*/
|
|
public int $uniqueFor = 600;
|
|
|
|
/**
|
|
* Create a new job instance.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function __construct()
|
|
{
|
|
//
|
|
}
|
|
|
|
/**
|
|
* Execute the job.
|
|
*
|
|
* @throws GuzzleException
|
|
*/
|
|
public function handle(): void
|
|
{
|
|
Log::debug('Update of all apps triggered!');
|
|
$apps = Application::all('appid')->toArray();
|
|
|
|
// We onl update the apps that are actually in use by items
|
|
// 1 sec delay after each update to throttle the requests
|
|
foreach ($apps as $appKey => $app) {
|
|
Application::getApp($app['appid']);
|
|
sleep(1);
|
|
}
|
|
|
|
Log::debug('Update of all apps finished!');
|
|
|
|
Cache::lock('updateApps')->forceRelease();
|
|
}
|
|
|
|
public function failed(Throwable $exception): void
|
|
{
|
|
Cache::lock('updateApps')->forceRelease();
|
|
|
|
Log::error(static::class . ' permanently failed', [
|
|
'exception' => $exception->getMessage(),
|
|
]);
|
|
}
|
|
}
|