mirror of
https://github.com/linuxserver/Heimdall.git
synced 2026-08-07 07:16:13 +00:00
KodeStar
5247349d33
CI ran `yarn && yarn dev` with no committed yarn.lock, so every run resolved the latest matching versions and dependency drift broke the pipeline in two independent ways: - select2 4.1.0 added engines.node ">=24" but the runner used node 22, so `yarn install` failed outright on every pull request. - webpack 5.108 removed lib/SizeFormatHelpers, which laravel-mix 6 still requires, so `yarn dev` would have failed the build regardless of node. Switch the workflow to `npm ci`, which installs the exact, known-good versions already pinned in package-lock.json (select2 4.0.13, webpack 5.100.1) and is verified to build and lint cleanly. Pin the runner to node 24 via actions/setup-node so the toolchain is explicit rather than tracking the runner default. Also pin select2 to ~4.0.13 in package.json so a future `npm install` cannot pull the incompatible 4.1.0 back in.
60 lines
1.5 KiB
YAML
60 lines
1.5 KiB
YAML
name: Tests (PHP)
|
|
|
|
on: [pull_request]
|
|
|
|
jobs:
|
|
tests:
|
|
name: Run tests
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
|
|
- name: Setup PHP, with composer and extensions
|
|
uses: shivammathur/setup-php@v2 #https://github.com/shivammathur/setup-php
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: mbstring, dom, fileinfo, mysql, libxml, xml, xmlwriter, dom, tokenizer, filter, json, phar, pcre, openssl, pdo, intl, curl
|
|
|
|
- name: Cache composer dependencies
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: vendor
|
|
key: composer-${{ hashFiles('composer.lock') }}
|
|
|
|
#- name: Run composer install
|
|
# run: composer install -n --prefer-dist
|
|
# env:
|
|
# APP_ENV: testing
|
|
|
|
- name: Prepare Laravel Application
|
|
run: |
|
|
cp .env.example .env
|
|
php artisan key:generate
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '24'
|
|
cache: 'npm'
|
|
|
|
- name: Install node modules and build assets
|
|
run: npm ci && npm run dev
|
|
|
|
- name: Run ESLint
|
|
run: npm run lint
|
|
|
|
- name: Run tests
|
|
run: php artisan test
|
|
env:
|
|
APP_ENV: testing
|
|
|
|
- name: Php code sniffer
|
|
run: ./vendor/bin/phpcs --config-set ignore_warnings_on_exit 1
|
|
|
|
- name: Upload artifacts
|
|
uses: actions/upload-artifact@master
|
|
if: failure()
|
|
with:
|
|
name: Logs
|
|
path: ./storage/logs
|