mirror of
https://github.com/cloudflare/cloudflared.git
synced 2026-06-23 04:10:20 +00:00
Miguel da Costa Martins Marcelino
e2a71cbecc
Trying to fix the following errors that showed up in CI, which became an issue when doing the pre-check work in https://gitlab.cfdata.org/cloudflare/tun/cloudflared/-/merge_requests/1814: ``` cmd/cloudflared/tunnel/cmd.go:454:29: Error return value of `metricsListener.Close` is not checked (errcheck) defer metricsListener.Close() ^ cmd/cloudflared/tunnel/cmd.go:573:18: Error return value of `file.Close` is not checked (errcheck) defer file.Close() ^ cmd/cloudflared/tunnel/cmd.go:574:13: Error return value of `fmt.Fprintf` is not checked (errcheck) fmt.Fprintf(file, "%d", os.Getpid()) ^ cmd/cloudflared/tunnel/cmd.go:47:2: G101: Potential hardcoded credentials: Password in URL (gosec) sentryDSN = "https://56a9c9fa5c364ab28f34b14f35ea0f1b:3e8827f6f9f740738eb11138f7bebb68@sentry.io/189878" ^ cmd/cloudflared/tunnel/cmd.go:348:23: G703: Path traversal via taint analysis (gosec) if err := os.Rename(tmpTraceFile.Name(), traceOutputFilepath); err != nil { ^ cmd/cloudflared/tunnel/cmd.go:354:21: G703: Path traversal via taint analysis (gosec) err := os.Remove(tmpTraceFile.Name()) ^ cmd/cloudflared/tunnel/cmd.go:568:15: G304: Potential file inclusion via variable (gosec) file, err := os.Create(expandedPath) ^ cmd/cloudflared/tunnel/cmd.go:260:10: ST1005: error strings should not be capitalized (staticcheck) return fmt.Errorf("Use `cloudflared tunnel run` to start tunnel %s", ref) ^ cmd/cloudflared/tunnel/cmd.go:1146:5: SA4011: ineffective break statement. Did you mean to break out of the outer loop? (staticcheck) break ^ 9 issues: * errcheck: 3 * gosec: 4 * staticcheck: 2 ```