From 69b8dfa3ea86116cf7ada9499bd2d2c3bc36a12a Mon Sep 17 00:00:00 2001 From: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Date: Wed, 30 Oct 2024 19:17:04 +0300 Subject: [PATCH] NOISSUE - Fix failing test (#292) * fix failing test Signed-off-by: Sammy Oina * remove junk code Signed-off-by: Sammy Oina * fix yml Signed-off-by: Sammy Oina --------- Signed-off-by: Sammy Oina --- codecov.yml | 2 +- pkg/manager/state_test.go | 2 +- pkg/progressbar/progress_test.go | 16 ---------------- 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/codecov.yml b/codecov.yml index bb564b54..a3ccb424 100644 --- a/codecov.yml +++ b/codecov.yml @@ -4,7 +4,7 @@ coverage: ignore: - "test/*" - - "**/mocks/**" + - "**/mocks/**" - "mocks/**" - "**/logging.go" - "**/metrics.go" diff --git a/pkg/manager/state_test.go b/pkg/manager/state_test.go index 38f156dd..65403dc2 100644 --- a/pkg/manager/state_test.go +++ b/pkg/manager/state_test.go @@ -36,7 +36,7 @@ func TestManagerStatus_String(t *testing.T) { {Stopped, "Stopped"}, {Warning, "Warning"}, {Disconnected, "Disconnected"}, - {ManagerStatus(4), "ManagerStatus(4)"}, + {ManagerStatus(5), "ManagerStatus(5)"}, {ManagerStatus(100), "ManagerStatus(100)"}, } diff --git a/pkg/progressbar/progress_test.go b/pkg/progressbar/progress_test.go index 7141ea9a..11acae69 100644 --- a/pkg/progressbar/progress_test.go +++ b/pkg/progressbar/progress_test.go @@ -61,14 +61,6 @@ func TestSendAlgorithm(t *testing.T) { algoStream.On("CloseAndRecv").Return(&agent.AlgoResponse{}, tc.closeRecvError) mockStream := &mockAlgoStream{stream: algoStream} - oldStdout := os.Stdout - _, w, _ := os.Pipe() - os.Stdout = w - defer func() { - w.Close() - os.Stdout = oldStdout - }() - err := pb.SendAlgorithm("Test Algorithm", algobuffer, reqBuffer, &mockStream.stream) assert.True(t, errors.Contains(err, tc.err)) }) @@ -123,14 +115,6 @@ func TestSendData(t *testing.T) { dataStream.On("CloseAndRecv").Return(&agent.DataResponse{}, tc.closeRecvError) mockStream := &mockDataStream{stream: dataStream} - oldStdout := os.Stdout - _, w, _ := os.Pipe() - os.Stdout = w - defer func() { - w.Close() - os.Stdout = oldStdout - }() - err := pb.SendData("Test Data", "test.txt", buffer, &mockStream.stream) assert.True(t, errors.Contains(err, tc.err)) })