From da6d18da4317b29fa44468bfdd42c6dd2cadebcf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Guill=C3=A9n?= <147244081+carloscgm@users.noreply.github.com> Date: Tue, 24 Feb 2026 17:12:26 +0100 Subject: [PATCH] Fix: CI correction and warning cleanup (#2943) (#2946) --- .github/workflows/ci.yml | 17 +++++++++++++---- app/lib/pages/tabs/send_tab.dart | 2 +- .../network/webrtc/signaling_provider.dart | 6 ++++-- .../network/webrtc/webrtc_receiver.dart | 7 ------- app/lib/util/native/file_picker.dart | 3 ++- app/lib/widget/list_tile/device_list_tile.dart | 1 - 6 files changed, 20 insertions(+), 16 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b5d098e..65b4e33b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,14 +15,18 @@ jobs: steps: - uses: actions/checkout@v6 - - uses: subosito/flutter-action@v2 + - name: Setup Flutter SDK + uses: flutter-actions/setup-flutter@v4 with: - flutter-version: ${{ env.FLUTTER_VERSION }} + version: ${{ env.FLUTTER_VERSION }} channel: "stable" - name: Dependencies (app) working-directory: app run: flutter pub get + - name: Dependencies (cargokit - rust_builder) + working-directory: app/rust_builder/cargokit/build_tool + run: flutter pub get - name: Remove gen directory (app) working-directory: app run: rm -rf lib/gen @@ -42,14 +46,18 @@ jobs: steps: - uses: actions/checkout@v6 - - uses: subosito/flutter-action@v2 + - name: Setup Flutter SDK + uses: flutter-actions/setup-flutter@v4 with: - flutter-version: ${{ env.FLUTTER_VERSION }} + version: ${{ env.FLUTTER_VERSION }} channel: "stable" - name: Dependencies (app) working-directory: app run: flutter pub get + - name: Dependencies (cargokit - rust_builder) + working-directory: app/rust_builder/cargokit/build_tool + run: flutter pub get - name: Analyze (app) working-directory: app run: flutter analyze @@ -94,3 +102,4 @@ jobs: else echo "Versions match." fi + diff --git a/app/lib/pages/tabs/send_tab.dart b/app/lib/pages/tabs/send_tab.dart index 5a260f08..dd1e40f6 100644 --- a/app/lib/pages/tabs/send_tab.dart +++ b/app/lib/pages/tabs/send_tab.dart @@ -25,12 +25,12 @@ import 'package:localsend_app/widget/custom_icon_button.dart'; import 'package:localsend_app/widget/dialogs/add_file_dialog.dart'; import 'package:localsend_app/widget/dialogs/send_mode_help_dialog.dart'; import 'package:localsend_app/widget/file_thumbnail.dart'; -import 'package:localsend_app/widget/responsive_wrap_view.dart'; import 'package:localsend_app/widget/list_tile/device_list_tile.dart'; import 'package:localsend_app/widget/list_tile/device_placeholder_list_tile.dart'; import 'package:localsend_app/widget/opacity_slideshow.dart'; import 'package:localsend_app/widget/responsive_builder.dart'; import 'package:localsend_app/widget/responsive_list_view.dart'; +import 'package:localsend_app/widget/responsive_wrap_view.dart'; import 'package:localsend_app/widget/rotating_widget.dart'; import 'package:refena_flutter/refena_flutter.dart'; import 'package:routerino/routerino.dart'; diff --git a/app/lib/provider/network/webrtc/signaling_provider.dart b/app/lib/provider/network/webrtc/signaling_provider.dart index 01758faf..d3ffda31 100644 --- a/app/lib/provider/network/webrtc/signaling_provider.dart +++ b/app/lib/provider/network/webrtc/signaling_provider.dart @@ -3,6 +3,7 @@ import 'dart:async'; import 'package:common/constants.dart'; import 'package:common/model/device.dart'; import 'package:dart_mappable/dart_mappable.dart'; +import 'package:flutter/foundation.dart'; import 'package:localsend_app/provider/device_info_provider.dart'; import 'package:localsend_app/provider/favorites_provider.dart'; import 'package:localsend_app/provider/network/nearby_devices_provider.dart'; @@ -74,11 +75,12 @@ class _SetupSignalingConnection extends AsyncGlobalAction { Future reduce() async { final settings = ref.read(settingsProvider); final deviceInfo = ref.read(deviceInfoProvider); - final security = ref.read(securityProvider); // TODO: Use persistent key final key = await crypto.generateKeyPair(); - print('private key: ${key.privateKey}'); + if (kDebugMode) { + print('private key: ${key.privateKey}'); + } LsSignalingConnection? connection; final stream = connect( diff --git a/app/lib/provider/network/webrtc/webrtc_receiver.dart b/app/lib/provider/network/webrtc/webrtc_receiver.dart index 5f605347..64136c95 100644 --- a/app/lib/provider/network/webrtc/webrtc_receiver.dart +++ b/app/lib/provider/network/webrtc/webrtc_receiver.dart @@ -1,12 +1,9 @@ -import 'package:collection/collection.dart'; import 'package:common/model/dto/file_dto.dart' as dart_model; -import 'package:common/model/file_status.dart'; import 'package:common/model/session_status.dart'; import 'package:common/model/stored_security_context.dart'; import 'package:dart_mappable/dart_mappable.dart'; import 'package:localsend_app/model/persistence/favorite_device.dart'; import 'package:localsend_app/model/state/server/receive_session_state.dart'; -import 'package:localsend_app/model/state/server/receiving_file.dart'; import 'package:localsend_app/model/state/settings_state.dart'; import 'package:localsend_app/pages/receive_page.dart'; import 'package:localsend_app/provider/network/webrtc/signaling_provider.dart'; @@ -39,8 +36,6 @@ class WebRTCReceiveService extends ReduxNotifier { final List _stunServers; final LsSignalingConnection _connection; final WsServerSdpMessage _offer; - final SettingsState _settings; - final List _favorites; final StoredSecurityContext _key; WebRTCReceiveService({ @@ -55,8 +50,6 @@ class WebRTCReceiveService extends ReduxNotifier { _stunServers = stunServers, _connection = connection, _offer = offer, - _settings = settings, - _favorites = favorites, _key = key; @override diff --git a/app/lib/util/native/file_picker.dart b/app/lib/util/native/file_picker.dart index 7f872706..077049f1 100644 --- a/app/lib/util/native/file_picker.dart +++ b/app/lib/util/native/file_picker.dart @@ -253,8 +253,9 @@ Future _pickMedia(BuildContext context, Ref ref) async { ); } + if (!context.mounted) return; + final oldBrightness = Theme.of(context).brightness; - // ignore: use_build_context_synchronously final List? result = await AssetPicker.pickAssets( context, pickerConfig: const AssetPickerConfig(maxAssets: 999, textDelegate: TranslatedAssetPickerTextDelegate()), diff --git a/app/lib/widget/list_tile/device_list_tile.dart b/app/lib/widget/list_tile/device_list_tile.dart index 8d8c279f..31a4c118 100644 --- a/app/lib/widget/list_tile/device_list_tile.dart +++ b/app/lib/widget/list_tile/device_list_tile.dart @@ -1,7 +1,6 @@ import 'package:common/model/device.dart'; import 'package:flutter/material.dart'; import 'package:localsend_app/util/device_type_ext.dart'; -import 'package:localsend_app/util/ip_helper.dart'; import 'package:localsend_app/widget/custom_progress_bar.dart'; import 'package:localsend_app/widget/device_bage.dart'; import 'package:localsend_app/widget/list_tile/custom_list_tile.dart';