NOISSUE - Improve CI (#3270)

Signed-off-by: dusan <borovcanindusan1@gmail.com>

.github/workflows/api-tests.yaml

@@ -19,6 +19,21 @@ on:
       - "journal/api/**"
       - "users/api/**"
       - "apidocs/openapi/**"
+  pull_request:
+    branches:
+      - main
+    paths:
+      - ".github/workflows/api-tests.yaml"
+      - "api/**"
+      - "auth/api/http/**"
+      - "channels/api/http/**"
+      - "clients/api/http/**"
+      - "domains/api/http/**"
+      - "groups/api/http/**"
+      - "http/api/**"
+      - "journal/api/**"
+      - "users/api/**"
+      - "apidocs/openapi/**"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -58,7 +73,6 @@ jobs:
         uses: dorny/paths-filter@v3
         id: changes
         with:
-          base: main
           filters: |
             workflow:
               - ".github/workflows/api-tests.yaml"

.github/workflows/build.yaml

@@ -7,80 +7,26 @@ on:
   push:
     branches:
       - main
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - '.github/workflows/**'
+      - 'LICENSE'
+      - 'MAINTAINERS'
+      - 'CODEOWNERS'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: false
 
 jobs:
-  test:
-    name: Test
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v6
-        with:
-          fetch-depth: 0
-          fetch-tags: true
-
-      - name: Setup Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: 1.25.x
-          cache-dependency-path: "go.sum"
-
-      - name: Set GOBIN
-        run: echo "GOBIN=$HOME/.local/bin" >> $GITHUB_ENV
-
-      - name: Add GOBIN to PATH
-        run: echo "$HOME/.local/bin" >> $GITHUB_PATH
-
-      - name: Run tests
-        run: |
-          make test
-
-      - name: Upload coverage
-        uses: codecov/codecov-action@v5
-        with:
-          token: ${{ secrets.CODECOV }}
-          files: ./coverage/*.out
-          verbose: true
-
-  compile-check:
-    name: Compile Check
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: true
-      matrix:
-        variant:
-          - name: rabbitmq
-            env: SMQ_MESSAGE_BROKER_TYPE=msg_rabbitmq
-            target: mqtt
-          - name: redis
-            env: SMQ_ES_TYPE=es_redis
-            target: mqtt
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v6
-
-      - name: Setup Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: 1.25.x
-          cache-dependency-path: "go.sum"
-
-      - name: Compile check for ${{ matrix.variant.name }}
-        run: |
-          ${{ matrix.variant.env }} make ${{ matrix.variant.target }}
+  lint-and-build:
+    uses: ./.github/workflows/lint-and-build.yaml
 
   build-and-push:
-    name: Build and Push
+    name: Build and Push Docker Images
     runs-on: ubuntu-latest
-    needs: [test, compile-check]
+    needs: [lint-and-build]
     permissions:
       contents: read
 
@@ -111,10 +57,3 @@ jobs:
         run: |
           make latest -j $(nproc)
 
-      - name: Trigger Helm Chart Deployment
-        if: success() && github.event_name == 'push' && github.ref == 'refs/heads/main'
-        uses: peter-evans/repository-dispatch@v4
-        with:
-          token: ${{ secrets.REPO_DISPATCH_TOKEN }}
-          repository: absmach/amdm
-          event-type: deploy-latest-smq-images

.github/workflows/check-generated-files.yaml

@@ -4,9 +4,6 @@
 name: Check the consistency of generated files
 
 on:
-  push:
-    branches:
-      - main
   pull_request:
     branches:
       - main
@@ -14,6 +11,10 @@ on:
 jobs:
   check-generated-files:
     runs-on: ubuntu-latest
+    env:
+      PROTOC_VERSION: "33.0"
+      PROTOC_GEN_GO_VERSION: "v1.36.10"
+      PROTOC_GEN_GO_GRPC_VERSION: "v1.5.1"
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -69,32 +70,18 @@ jobs:
               - "journal/journal.go"
               - "consumers/notifier.go"
 
-      - name: Set up protoc
+      - name: Install Protoc
+        if: steps.changes.outputs.proto == 'true'
+        uses: arduino/setup-protoc@v3
+        with:
+          version: ${{ env.PROTOC_VERSION }}
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Install Go Protobuf Plugins
         if: steps.changes.outputs.proto == 'true'
         run: |
-          PROTOC_VERSION=33.0
-          PROTOC_GEN_VERSION=v1.36.10
-          PROTOC_GRPC_VERSION=v1.5.1
-
-          # Export the variables so they are available in future steps
-          echo "PROTOC_VERSION=$PROTOC_VERSION" >> $GITHUB_ENV
-          echo "PROTOC_GEN_VERSION=$PROTOC_GEN_VERSION" >> $GITHUB_ENV
-          echo "PROTOC_GRPC_VERSION=$PROTOC_GRPC_VERSION" >> $GITHUB_ENV
-
-          # Download and install protoc
-          PROTOC_ZIP=protoc-$PROTOC_VERSION-linux-x86_64.zip
-          curl -0L -o $PROTOC_ZIP https://github.com/protocolbuffers/protobuf/releases/download/v$PROTOC_VERSION/$PROTOC_ZIP
-          unzip -o $PROTOC_ZIP -d protoc3
-          sudo mv protoc3/bin/* /usr/local/bin/
-          sudo mv protoc3/include/* /usr/local/include/
-          rm -rf $PROTOC_ZIP protoc3
-
-          # Install protoc-gen-go and protoc-gen-go-grpc
-          go install google.golang.org/protobuf/cmd/protoc-gen-go@$PROTOC_GEN_VERSION
-          go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@$PROTOC_GRPC_VERSION
-
-          # Add protoc to the PATH
-          export PATH=$PATH:/usr/local/bin/protoc
+          go install google.golang.org/protobuf/cmd/protoc-gen-go@$PROTOC_GEN_GO_VERSION
+          go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@$PROTOC_GEN_GO_GRPC_VERSION
 
       - name: Check Protobuf is up to Date
         if: steps.changes.outputs.proto == 'true'
@@ -110,7 +97,7 @@ jobs:
               echo "Error: Proto file and generated Go file $p are out of sync!"
               echo "Here is the difference:"
               diff $p $p.tmp || true
-              echo "Please run 'make proto' with protoc version $PROTOC_VERSION, protoc-gen-go version $PROTOC_GEN_VERSION and protoc-gen-go-grpc version $PROTOC_GRPC_VERSION and commit the changes."
+              echo "Please run 'make proto' with protoc version $PROTOC_VERSION, protoc-gen-go version $PROTOC_GEN_GO_VERSION and protoc-gen-go-grpc version $PROTOC_GEN_GO_GRPC_VERSION and commit the changes."
               exit 1
             fi
           done

.github/workflows/check-license.yaml

@@ -4,9 +4,6 @@
 name: Check License Header
 
 on:
-  push:
-    branches:
-      - main
   pull_request:
     branches:
       - main

.github/workflows/lint-and-build.yaml

@@ -0,0 +1,74 @@
+# Copyright (c) Abstract Machines
+# SPDX-License-Identifier: Apache-2.0
+
+name: Lint and Build
+
+on:
+  workflow_call:
+
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: 1.25.x
+          cache-dependency-path: "go.sum"
+
+      - name: Run linters
+        uses: golangci/golangci-lint-action@v9
+        with:
+          version: v2.4.0
+          args: --config ./tools/config/.golangci.yaml
+
+  build:
+    name: Build All Binaries
+    runs-on: ubuntu-latest
+    needs: lint
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: 1.25.x
+          cache-dependency-path: "go.sum"
+
+      - name: Build all binaries
+        run: |
+          make all -j $(nproc)
+
+  compile-check:
+    name: Compile Check ${{ matrix.variant.name }}
+    runs-on: ubuntu-latest
+    needs: lint
+    strategy:
+      fail-fast: true
+      matrix:
+        variant:
+          - name: rabbitmq
+            env: SMQ_MESSAGE_BROKER_TYPE=msg_rabbitmq
+            target: mqtt
+          - name: redis
+            env: SMQ_ES_TYPE=es_redis
+            target: mqtt
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: 1.25.x
+          cache-dependency-path: "go.sum"
+
+      - name: Compile check for ${{ matrix.variant.name }}
+        run: |
+          ${{ matrix.variant.env }} make ${{ matrix.variant.target }}

.github/workflows/tests.yaml

@@ -7,6 +7,12 @@ on:
   push:
     branches:
       - main
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - 'LICENSE'
+      - 'MAINTAINERS'
+      - 'CODEOWNERS'
   pull_request:
     branches:
       - main
@@ -16,20 +22,13 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  lint:
-    name: Lint
+  check-certs:
+    name: Check Certs
     runs-on: ubuntu-latest
-
     steps:
       - name: Checkout Code
         uses: actions/checkout@v6
 
-      - name: Setup Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: 1.25.x
-          cache-dependency-path: "go.sum"
-
       - name: Fetch Certs
         run: |
           make fetch_certs
@@ -41,25 +40,9 @@ jobs:
             exit 0
           fi
 
-      - name: Install protolint
-        run: |
-          go install github.com/yoheimuta/protolint/cmd/protolint@latest
-
-      - name: Lint Protobuf Files
-        run: |
-          protolint .
-
-      - name: Run linters
-        uses: golangci/golangci-lint-action@v9
-        with:
-          version: v2.4.0
-          args: --config ./tools/config/.golangci.yaml
-
-  build:
-    name: Build
+  lint-proto:
+    name: Lint Proto
     runs-on: ubuntu-latest
-    needs: lint
-
     steps:
       - name: Checkout Code
         uses: actions/checkout@v6
@@ -70,21 +53,19 @@ jobs:
           go-version: 1.25.x
           cache-dependency-path: "go.sum"
 
-      - name: Download all dependencies
+      - name: Install protolint
         run: |
-          go mod download
+          go install github.com/yoheimuta/protolint/cmd/protolint@latest
 
-      - name: Build all Binaries
+      - name: Lint Protobuf Files
         run: |
-          make all -j $(nproc)
+          protolint .
+
+  lint-and-build:
+    needs: [check-certs, lint-proto]
+    uses: ./.github/workflows/lint-and-build.yaml
 
-      - name: Compile check for rabbitmq
-        run: |
-          SMQ_MESSAGE_BROKER_TYPE=msg_rabbitmq make mqtt
 
-      - name: Compile check for redis
-        run: |
-          SMQ_ES_TYPE=es_redis make mqtt
 
   detect-changes:
     name: Detect Changes
@@ -102,7 +83,6 @@ jobs:
         uses: dorny/paths-filter@v3
         id: changes
         with:
-          base: main
           filters: |
             workflow:
               - ".github/workflows/tests.yaml"
@@ -327,7 +307,7 @@ jobs:
   run-tests:
     name: Test ${{ matrix.module }}
     runs-on: ubuntu-latest
-    needs: [lint, detect-changes, build]
+    needs: [lint-and-build, detect-changes]
     if: needs.detect-changes.outputs.modules != '[]'
     strategy:
       fail-fast: true