diff --git a/auth/service.go b/auth/service.go index 09a78461d..7f513f934 100644 --- a/auth/service.go +++ b/auth/service.go @@ -336,7 +336,7 @@ func (svc service) refreshKey(ctx context.Context, token string, key Key) (Token if k.Type != RefreshKey { return Token{}, errIssueUser } - ok, err := svc.tokensCache.IsActive(ctx, key.ID) + ok, err := svc.tokensCache.IsActive(ctx, k.ID) if err != nil { return Token{}, errors.Wrap(svcerr.ErrViewEntity, err) } diff --git a/auth/service_test.go b/auth/service_test.go index 219e6c031..643f37784 100644 --- a/auth/service_test.go +++ b/auth/service_test.go @@ -103,6 +103,7 @@ func TestIssue(t *testing.T) { assert.Nil(t, err, fmt.Sprintf("Issuing API key expected to succeed: %s", err)) refreshkey := auth.Key{ + ID: testsutil.GenerateUUID(t), IssuedAt: time.Now(), ExpiresAt: time.Now().Add(refreshDuration), Subject: userID, @@ -398,7 +399,7 @@ func TestIssue(t *testing.T) { tokenizerCall := tokenizer.On("Issue", mock.Anything, mock.Anything).Return(tc.token, tc.issueErr) tokenizerCall1 := tokenizer.On("Parse", mock.Anything, tc.token).Return(tc.parseRes, tc.parseErr) tokenizerCall2 := tokenizer.On("Revoke", mock.Anything, tc.token).Return(tc.parseErr) - cacheCall := tokensCache.On("IsActive", context.Background(), tc.key.ID).Return(tc.cacheRes, tc.cacheErr) + cacheCall := tokensCache.On("IsActive", context.Background(), tc.parseRes.ID).Return(tc.cacheRes, tc.cacheErr) policyCall := pEvaluator.On("CheckPolicy", mock.Anything, policies.Policy{ Subject: tc.key.Subject, SubjectType: policies.UserType, diff --git a/docker/.env b/docker/.env index 9ae2b78d6..002536e03 100644 --- a/docker/.env +++ b/docker/.env @@ -238,8 +238,6 @@ SMQ_USERS_ADMIN_USERNAME=admin SMQ_USERS_ADMIN_FIRST_NAME=super SMQ_USERS_ADMIN_LAST_NAME=admin SMQ_USERS_PASS_REGEX=^.{8,}$ -SMQ_USERS_ACCESS_TOKEN_DURATION=15m -SMQ_USERS_REFRESH_TOKEN_DURATION=24h SMQ_USERS_HTTP_HOST=users SMQ_USERS_HTTP_PORT=9002 SMQ_USERS_HTTP_SERVER_CERT= @@ -263,8 +261,6 @@ SMQ_USERS_SECRET_KEY=HyE2D4RUt9nnKG6v8zKEqAp6g6ka8hhZsqUpzgKvnwpXrNVQSH SMQ_USERS_ADMIN_EMAIL=admin@example.com SMQ_USERS_ADMIN_PASSWORD=12345678 SMQ_USERS_PASS_REGEX=^.{8,}$ -SMQ_USERS_ACCESS_TOKEN_DURATION=15m -SMQ_USERS_REFRESH_TOKEN_DURATION=24h SMQ_USERS_ALLOW_SELF_REGISTER=true SMQ_OAUTH_UI_REDIRECT_URL=http://localhost:9095${SMQ_UI_PATH_PREFIX}/tokens/secure SMQ_OAUTH_UI_ERROR_URL=http://localhost:9095${SMQ_UI_PATH_PREFIX}/error diff --git a/docker/docker-compose.yaml b/docker/docker-compose.yaml index dc82038fb..8b1bf2fd5 100644 --- a/docker/docker-compose.yaml +++ b/docker/docker-compose.yaml @@ -862,8 +862,6 @@ services: SMQ_USERS_ADMIN_FIRST_NAME: ${SMQ_USERS_ADMIN_FIRST_NAME} SMQ_USERS_ADMIN_LAST_NAME: ${SMQ_USERS_ADMIN_LAST_NAME} SMQ_USERS_PASS_REGEX: ${SMQ_USERS_PASS_REGEX} - SMQ_USERS_ACCESS_TOKEN_DURATION: ${SMQ_USERS_ACCESS_TOKEN_DURATION} - SMQ_USERS_REFRESH_TOKEN_DURATION: ${SMQ_USERS_REFRESH_TOKEN_DURATION} SMQ_USERS_HTTP_HOST: ${SMQ_USERS_HTTP_HOST} SMQ_USERS_HTTP_PORT: ${SMQ_USERS_HTTP_PORT} SMQ_USERS_HTTP_SERVER_CERT: ${SMQ_USERS_HTTP_SERVER_CERT}