Files
Steve Munene 7fb5dd7b55 NOISSUE - Refactor listing for rules and reports (#433)
* add access control to rules engine

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* update authorization method

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* revert code

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* initial implementation

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* remove domain from method

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* fix failing linter

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* fix userid parameter

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* update checksuperadmin method

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* revert changes

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

* address comments

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

---------

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
2026-03-16 14:39:49 +01:00

664 lines
17 KiB
Go

// Copyright (c) Abstract Machines
// SPDX-License-Identifier: Apache-2.0
package postgres
import (
"context"
"database/sql"
"fmt"
"strings"
"time"
mgPolicies "github.com/absmach/magistrala/pkg/policies"
"github.com/absmach/magistrala/reports"
api "github.com/absmach/supermq/api/http"
"github.com/absmach/supermq/pkg/errors"
repoerr "github.com/absmach/supermq/pkg/errors/repository"
"github.com/absmach/supermq/pkg/postgres"
rolesPostgres "github.com/absmach/supermq/pkg/roles/repo/postgres"
)
const (
rolesTableNamePrefix = "reports"
entityTableName = "report_config"
entityIDColumnName = "id"
)
type PostgresRepository struct {
DB postgres.Database
eh errors.Handler
rolesPostgres.Repository
}
func NewRepository(db postgres.Database) reports.Repository {
rolesRepo := rolesPostgres.NewRepository(db, mgPolicies.ReportsType, rolesTableNamePrefix, entityTableName, entityIDColumnName)
errHandlerOptions := []errors.HandlerOption{
postgres.WithDuplicateErrors(NewDuplicateErrors()),
}
return &PostgresRepository{
DB: db,
eh: postgres.NewErrorHandler(errHandlerOptions...),
Repository: rolesRepo,
}
}
func (repo *PostgresRepository) AddReportConfig(ctx context.Context, cfg reports.ReportConfig) (reports.ReportConfig, error) {
q := `
INSERT INTO report_config (id, name, description, domain_id, config, metrics,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status, report_template)
VALUES (:id, :name, :description, :domain_id, :config, :metrics,
:email, :start_datetime, :due, :recurring, :recurring_period, :created_at, :created_by, :updated_at, :updated_by, :status, :report_template)
RETURNING id, name, description, domain_id, config, metrics,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status, report_template;
`
dbr, err := reportToDb(cfg)
if err != nil {
return reports.ReportConfig{}, repo.eh.HandleError(repoerr.ErrCreateEntity, err)
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return reports.ReportConfig{}, repo.eh.HandleError(repoerr.ErrCreateEntity, err)
}
defer row.Close()
var dbReport dbReport
if row.Next() {
if err := row.StructScan(&dbReport); err != nil {
return reports.ReportConfig{}, repo.eh.HandleError(repoerr.ErrCreateEntity, err)
}
}
report, err := dbToReport(dbReport)
if err != nil {
return reports.ReportConfig{}, repo.eh.HandleError(repoerr.ErrCreateEntity, err)
}
return report, nil
}
func (repo *PostgresRepository) ViewReportConfig(ctx context.Context, id string) (reports.ReportConfig, error) {
q := `
SELECT id, name, description, domain_id, config, metrics, report_template,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status
FROM report_config
WHERE id = $1;
`
row := repo.DB.QueryRowxContext(ctx, q, id)
if err := row.Err(); err != nil {
return reports.ReportConfig{}, err
}
var dbr dbReport
if err := row.StructScan(&dbr); err != nil {
if err == sql.ErrNoRows {
return reports.ReportConfig{}, repoerr.ErrNotFound
}
return reports.ReportConfig{}, err
}
rpt, err := dbToReport(dbr)
if err != nil {
return reports.ReportConfig{}, err
}
return rpt, nil
}
func (repo *PostgresRepository) RetrieveByIDWithRoles(ctx context.Context, id, memberID string) (reports.ReportConfig, error) {
query := `
WITH selected_report AS (
SELECT
r.id,
r.domain_id
FROM
report_config r
WHERE
r.id = :id
LIMIT 1
),
selected_report_roles AS (
SELECT
rr.entity_id AS report_id,
rrm.member_id AS member_id,
rr.id AS role_id,
rr."name" AS role_name,
jsonb_agg(DISTINCT rra."action") AS actions,
'direct' AS access_type,
'' AS access_provider_id
FROM
reports_roles rr
JOIN
reports_role_members rrm ON rr.id = rrm.role_id
JOIN
reports_role_actions rra ON rr.id = rra.role_id
JOIN
selected_report sr ON sr.id = rr.entity_id
AND rrm.member_id = :member_id
GROUP BY
rr.entity_id, rr.id, rr.name, rrm.member_id
),
selected_domain_roles AS (
SELECT
sr.id AS report_id,
drm.member_id AS member_id,
dr.id AS role_id,
dr."name" AS role_name,
jsonb_agg(DISTINCT all_actions."action") AS actions,
'domain' AS access_type,
dr.entity_id AS access_provider_id
FROM
domains d
JOIN
selected_report sr ON sr.domain_id = d.id
JOIN
domains_roles dr ON dr.entity_id = d.id
JOIN
domains_role_members drm ON dr.id = drm.role_id
JOIN
domains_role_actions dra ON dr.id = dra.role_id
JOIN
domains_role_actions all_actions ON dr.id = all_actions.role_id
WHERE
drm.member_id = :member_id
AND dra."action" LIKE 'report%'
GROUP BY
sr.id, dr.entity_id, dr.id, dr."name", drm.member_id
),
all_roles AS (
SELECT
srr.report_id,
srr.member_id,
srr.role_id,
srr.role_name,
srr.actions,
srr.access_type,
srr.access_provider_id
FROM
selected_report_roles srr
UNION
SELECT
sdr.report_id,
sdr.member_id,
sdr.role_id,
sdr.role_name,
sdr.actions,
sdr.access_type,
sdr.access_provider_id
FROM
selected_domain_roles sdr
),
final_roles AS (
SELECT
ar.report_id,
ar.member_id,
jsonb_agg(
jsonb_build_object(
'role_id', ar.role_id,
'role_name', ar.role_name,
'actions', ar.actions,
'access_type', ar.access_type,
'access_provider_id', ar.access_provider_id
)
) AS roles
FROM all_roles ar
GROUP BY
ar.report_id, ar.member_id
)
SELECT
r2.id,
r2."name",
r2.description,
r2.domain_id,
r2.status,
r2.created_at,
r2.created_by,
r2.updated_at,
r2.updated_by,
r2.due,
r2.recurring,
r2.recurring_period,
r2.start_datetime,
r2.config,
r2.email,
r2.metrics,
r2.report_template,
fr.member_id,
fr.roles
FROM report_config r2
JOIN final_roles fr ON fr.report_id = r2.id
`
parameters := map[string]any{
"id": id,
"member_id": memberID,
}
row, err := repo.DB.NamedQueryContext(ctx, query, parameters)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
defer row.Close()
dbreport := dbReport{}
if !row.Next() {
return reports.ReportConfig{}, repoerr.ErrNotFound
}
if err := row.StructScan(&dbreport); err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
cfg, err := dbToReport(dbreport)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
return cfg, nil
}
func (repo *PostgresRepository) UpdateReportConfigStatus(ctx context.Context, cfg reports.ReportConfig) (reports.ReportConfig, error) {
q := `UPDATE report_config SET status = :status, updated_at = :updated_at, updated_by = :updated_by
WHERE id = :id
RETURNING id, name, description, domain_id, metrics, email, config,
start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status;`
dbRpt, err := reportToDb(cfg)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbRpt)
if err != nil {
return reports.ReportConfig{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
}
defer row.Close()
dbr := dbReport{}
if row.Next() {
if err := row.StructScan(&dbr); err != nil {
return reports.ReportConfig{}, err
}
res, err := dbToReport(dbr)
if err != nil {
return reports.ReportConfig{}, err
}
return res, err
}
return reports.ReportConfig{}, repoerr.ErrNotFound
}
func (repo *PostgresRepository) UpdateReportConfig(ctx context.Context, cfg reports.ReportConfig) (reports.ReportConfig, error) {
var query []string
if cfg.Name != "" {
query = append(query, "name = :name")
}
if cfg.Description != "" {
query = append(query, "description = :description")
}
if len(cfg.Metrics) > 0 {
query = append(query, "metrics = :metrics")
}
if cfg.Email != nil {
query = append(query, "email = :email")
}
if cfg.Config != nil {
query = append(query, "config = :config")
}
var q string
if len(query) > 0 {
q = strings.Join(query, ", ")
}
q = fmt.Sprintf(`
UPDATE report_config
SET %s,
updated_at = :updated_at, updated_by = :updated_by
WHERE id = :id
RETURNING id, name, description, domain_id, config, metrics,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status;
`, q)
dbr, err := reportToDb(cfg)
if err != nil {
return reports.ReportConfig{}, err
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return reports.ReportConfig{}, err
}
defer row.Close()
var dbReport dbReport
if !row.Next() {
if err := row.Err(); err != nil {
return reports.ReportConfig{}, err
}
return reports.ReportConfig{}, repoerr.ErrNotFound
}
if err := row.StructScan(&dbReport); err != nil {
return reports.ReportConfig{}, err
}
rpt, err := dbToReport(dbReport)
if err != nil {
return reports.ReportConfig{}, err
}
return rpt, nil
}
func (repo *PostgresRepository) UpdateReportSchedule(ctx context.Context, cfg reports.ReportConfig) (reports.ReportConfig, error) {
q := `
UPDATE report_config
SET start_datetime = :start_datetime, due = :due, recurring = :recurring,
recurring_period = :recurring_period, updated_at = :updated_at, updated_by = :updated_by WHERE id = :id
RETURNING id, name, description, domain_id, config, metrics,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status;
`
dbr, err := reportToDb(cfg)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return reports.ReportConfig{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
}
defer row.Close()
var dbReport dbReport
if !row.Next() {
if err := row.Err(); err != nil {
return reports.ReportConfig{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
}
return reports.ReportConfig{}, repoerr.ErrNotFound
}
if err := row.StructScan(&dbReport); err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
report, err := dbToReport(dbReport)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
return report, nil
}
func (repo *PostgresRepository) RemoveReportConfig(ctx context.Context, id string) error {
q := `
DELETE FROM report_config
WHERE id = $1;
`
result, err := repo.DB.ExecContext(ctx, q, id)
if err != nil {
return err
}
if _, err := result.RowsAffected(); err != nil {
return repoerr.ErrNotFound
}
return nil
}
func (repo *PostgresRepository) ListAllReportsConfig(ctx context.Context, pm reports.PageMeta) (reports.ReportConfigPage, error) {
listReportsQuery := `
SELECT id, name, description, domain_id, metrics, email, config,
start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status
FROM report_config rc %s %s %s;
`
pq := pageReportQuery(pm)
orderClause := reportsOrderClause(pm)
pgData := reportsPageData(pm)
q := fmt.Sprintf(listReportsQuery, pq, orderClause, pgData)
rows, err := repo.DB.NamedQueryContext(ctx, q, pm)
if err != nil {
return reports.ReportConfigPage{}, err
}
defer rows.Close()
cfgs := []reports.ReportConfig{}
for rows.Next() {
var r dbReport
if err := rows.StructScan(&r); err != nil {
return reports.ReportConfigPage{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
rpt, err := dbToReport(r)
if err != nil {
return reports.ReportConfigPage{}, err
}
cfgs = append(cfgs, rpt)
}
cq := fmt.Sprintf(`SELECT COUNT(*) FROM report_config rc %s;`, pq)
total, err := postgres.Total(ctx, repo.DB, cq, pm)
if err != nil {
return reports.ReportConfigPage{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
pm.Total = total
ret := reports.ReportConfigPage{
PageMeta: pm,
ReportConfigs: cfgs,
}
return ret, nil
}
func (repo *PostgresRepository) ListUserReportsConfig(ctx context.Context, userID string, pm reports.PageMeta) (reports.ReportConfigPage, error) {
pq := pageReportQuery(pm)
orderClause := reportsOrderClause(pm)
pgData := reportsPageData(pm)
pm.UserID = userID
userJoin := `
INNER JOIN reports_roles rr ON rr.entity_id = rc.id
INNER JOIN reports_role_members rrm ON rrm.role_id = rr.id AND rrm.member_id = :user_id
`
whereClause := pq
innerQ := fmt.Sprintf(`
SELECT DISTINCT rc.id, rc.name, rc.description, rc.domain_id, rc.metrics, rc.email, rc.config,
rc.start_datetime, rc.due, rc.recurring, rc.recurring_period, rc.created_at, rc.created_by, rc.updated_at, rc.updated_by, rc.status
FROM report_config rc
%s
%s
`, userJoin, whereClause)
q := fmt.Sprintf(`
SELECT * FROM (%s) AS sub %s %s;
`, innerQ, orderClause, pgData)
rows, err := repo.DB.NamedQueryContext(ctx, q, pm)
if err != nil {
return reports.ReportConfigPage{}, err
}
defer rows.Close()
cfgs := []reports.ReportConfig{}
for rows.Next() {
var r dbReport
if err := rows.StructScan(&r); err != nil {
return reports.ReportConfigPage{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
rpt, err := dbToReport(r)
if err != nil {
return reports.ReportConfigPage{}, err
}
cfgs = append(cfgs, rpt)
}
cq := fmt.Sprintf(`SELECT COUNT(*) FROM (%s) AS count_sub;`, innerQ)
total, err := postgres.Total(ctx, repo.DB, cq, pm)
if err != nil {
return reports.ReportConfigPage{}, errors.Wrap(repoerr.ErrViewEntity, err)
}
pm.Total = total
return reports.ReportConfigPage{
PageMeta: pm,
ReportConfigs: cfgs,
}, nil
}
func (repo *PostgresRepository) UpdateReportDue(ctx context.Context, id string, due time.Time) (reports.ReportConfig, error) {
q := `
UPDATE report_config
SET due = :due, updated_at = :updated_at WHERE id = :id
RETURNING id, name, description, domain_id, config, metrics,
email, start_datetime, due, recurring, recurring_period, created_at, created_by, updated_at, updated_by, status;
`
dbr := dbReport{
ID: id,
UpdatedAt: time.Now().UTC(),
Due: sql.NullTime{Time: due},
}
if !due.IsZero() {
dbr.Due.Valid = true
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return reports.ReportConfig{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
}
defer row.Close()
var dbReport dbReport
if !row.Next() {
if err := row.Err(); err != nil {
return reports.ReportConfig{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
}
return reports.ReportConfig{}, repoerr.ErrNotFound
}
if err := row.StructScan(&dbReport); err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
report, err := dbToReport(dbReport)
if err != nil {
return reports.ReportConfig{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
}
return report, nil
}
func (repo *PostgresRepository) UpdateReportTemplate(ctx context.Context, domainID, reportID string, template reports.ReportTemplate) error {
q := `
UPDATE report_config
SET report_template = :report_template, updated_at = :updated_at
WHERE id = :id AND domain_id = :domain_id`
dbr := dbReport{
ID: reportID,
DomainID: domainID,
UpdatedAt: time.Now().UTC(),
ReportTemplate: template,
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return errors.Wrap(repoerr.ErrUpdateEntity, err)
}
defer row.Close()
return nil
}
func (repo *PostgresRepository) ViewReportTemplate(ctx context.Context, domainID, reportID string) (reports.ReportTemplate, error) {
q := `
SELECT COALESCE(report_template, '') as report_template
FROM report_config
WHERE id = $1 AND domain_id = $2`
var template reports.ReportTemplate
err := repo.DB.QueryRowxContext(ctx, q, reportID, domainID).Scan(&template)
if err != nil {
if err == sql.ErrNoRows {
return "", repoerr.ErrNotFound
}
return "", errors.Wrap(repoerr.ErrViewEntity, err)
}
return template, nil
}
func (repo *PostgresRepository) DeleteReportTemplate(ctx context.Context, domainID, reportID string) error {
q := `
UPDATE report_config
SET report_template = '', updated_at = :updated_at
WHERE id = :id AND domain_id = :domain_id`
dbr := dbReport{
ID: reportID,
DomainID: domainID,
UpdatedAt: time.Now().UTC(),
}
row, err := repo.DB.NamedQueryContext(ctx, q, dbr)
if err != nil {
return errors.Wrap(repoerr.ErrRemoveEntity, err)
}
defer row.Close()
return nil
}
func reportsOrderClause(pm reports.PageMeta) string {
dir := api.DescDir
if pm.Dir == api.AscDir {
dir = api.AscDir
}
switch pm.Order {
case api.NameKey:
return fmt.Sprintf("ORDER BY name %s, id %s", dir, dir)
case api.CreatedAtOrder:
return fmt.Sprintf("ORDER BY created_at %s, id %s", dir, dir)
default:
return fmt.Sprintf("ORDER BY COALESCE(updated_at, created_at) %s, id %s", dir, dir)
}
}
func reportsPageData(pm reports.PageMeta) string {
pgData := ""
if pm.Limit != 0 {
pgData = "LIMIT :limit"
}
if pm.Offset != 0 {
pgData += " OFFSET :offset"
}
return pgData
}
func pageReportQuery(pm reports.PageMeta) string {
var query []string
if pm.Status != reports.AllStatus {
query = append(query, "rc.status = :status")
}
if pm.Domain != "" {
query = append(query, "rc.domain_id = :domain_id")
}
if pm.ScheduledBefore != nil {
query = append(query, "rc.due < :scheduled_before")
}
if pm.ScheduledAfter != nil {
query = append(query, "rc.due > :scheduled_after")
}
if pm.Name != "" {
query = append(query, "rc.name ILIKE '%' || :name || '%'")
}
var q string
if len(query) > 0 {
q = fmt.Sprintf("WHERE %s", strings.Join(query, " AND "))
}
return q
}