homelab/dozzle
1
0
Fork 0
mirror of https://github.com/amir20/dozzle.git synced 2026-06-23 04:10:12 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Remove Env from InspectContainerResult to prevent leaking container environment variables to cloud

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Amir Raminfar
2026-04-04 19:44:36 -07:00
parent 317c141f65
commit e079e5fc43
3 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/cloud/tools_containers.go
-1
View File
@@ -182,7 +182,6 @@ func executeInspectContainer(argsJSON string, hostService ToolHostService, label
Labels: c.Labels,
MemoryLimit: c.MemoryLimit,
CpuLimit: c.CPULimit,
Env: c.Env,
Ports: c.Ports,
Mounts: c.Mounts,
RestartPolicy: c.RestartPolicy,
proto/cloud/cloud.pb.go
+3 -12
View File
@@ -1160,7 +1160,6 @@ type InspectContainerResult struct {
Labels map[string]string `protobuf:"bytes,11,rep,name=labels,proto3" json:"labels,omitempty" protobuf_key:"bytes,1,opt,name=key" protobuf_val:"bytes,2,opt,name=value"`
MemoryLimit uint64 `protobuf:"varint,12,opt,name=memory_limit,json=memoryLimit,proto3" json:"memory_limit,omitempty"`
CpuLimit float64 `protobuf:"fixed64,13,opt,name=cpu_limit,json=cpuLimit,proto3" json:"cpu_limit,omitempty"`
Env []string `protobuf:"bytes,14,rep,name=env,proto3" json:"env,omitempty"`
Ports []string `protobuf:"bytes,15,rep,name=ports,proto3" json:"ports,omitempty"`
Mounts []string `protobuf:"bytes,16,rep,name=mounts,proto3" json:"mounts,omitempty"`
RestartPolicy string `protobuf:"bytes,17,opt,name=restart_policy,json=restartPolicy,proto3" json:"restart_policy,omitempty"`
@@ -1297,13 +1296,6 @@ func (x *InspectContainerResult) GetCpuLimit() float64 {
return 0
}
func (x *InspectContainerResult) GetEnv() []string {
if x != nil {
return x.Env
}
return nil
}
func (x *InspectContainerResult) GetPorts() []string {
if x != nil {
return x.Ports
@@ -1485,7 +1477,7 @@ const file_cloud_proto_rawDesc = "" +
"\x05level\x18\x04 \x01(\tR\x05level\"c\n" +
"\x0fFetchLogsResult\x12%\n" +
"\x0econtainer_name\x18\x01 \x01(\tR\rcontainerName\x12)\n" +
"\aentries\x18\x02 \x03(\v2\x0f.cloud.LogEntryR\aentries\"\xf2\x04\n" +
"\aentries\x18\x02 \x03(\v2\x0f.cloud.LogEntryR\aentries\"\xeb\x04\n" +
"\x16InspectContainerResult\x12\x0e\n" +
"\x02id\x18\x01 \x01(\tR\x02id\x12\x12\n" +
"\x04name\x18\x02 \x01(\tR\x04name\x12\x14\n" +
@@ -1503,15 +1495,14 @@ const file_cloud_proto_rawDesc = "" +
"\ahost_id\x18\x13 \x01(\tR\x06hostId\x12A\n" +
"\x06labels\x18\v \x03(\v2).cloud.InspectContainerResult.LabelsEntryR\x06labels\x12!\n" +
"\fmemory_limit\x18\f \x01(\x04R\vmemoryLimit\x12\x1b\n" +
"\tcpu_limit\x18\r \x01(\x01R\bcpuLimit\x12\x10\n" +
"\x03env\x18\x0e \x03(\tR\x03env\x12\x14\n" +
"\tcpu_limit\x18\r \x01(\x01R\bcpuLimit\x12\x14\n" +
"\x05ports\x18\x0f \x03(\tR\x05ports\x12\x16\n" +
"\x06mounts\x18\x10 \x03(\tR\x06mounts\x12%\n" +
"\x0erestart_policy\x18\x11 \x01(\tR\rrestartPolicy\x12!\n" +
"\fnetwork_mode\x18\x12 \x01(\tR\vnetworkMode\x1a9\n" +
"\vLabelsEntry\x12\x10\n" +
"\x03key\x18\x01 \x01(\tR\x03key\x12\x14\n" +
"\x05value\x18\x02 \x01(\tR\x05value:\x028\x01\"c\n" +
"\x05value\x18\x02 \x01(\tR\x05value:\x028\x01J\x04\b\x0e\x10\x0fR\x03env\"c\n" +
"\fActionResult\x12\x18\n" +
"\asuccess\x18\x01 \x01(\bR\asuccess\x12!\n" +
"\fcontainer_id\x18\x02 \x01(\tR\vcontainerId\x12\x16\n" +
protos/cloud.proto
+2 -1
View File
@@ -136,7 +136,8 @@ message InspectContainerResult {
map<string, string> labels = 11;
uint64 memory_limit = 12;
double cpu_limit = 13;
repeated string env = 14;
reserved 14;
reserved "env";
repeated string ports = 15;
repeated string mounts = 16;
string restart_policy = 17;