homelab/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2026-06-22 20:00:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(rate-limit): increase auth limit defaults

Browse Source 
This is a moderate increase from about 2 req/minute to 2.6 req/minute
with an increase of the window to 15 minutes. Switching between
accounts a few times should be covered by the higher rate limit.
At the same time, the window increase reduces the attack/abuse chance
again.

Fixes #6471

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
This commit is contained in:
Erik Michelson
2026-05-13 22:46:45 +02:00
committed by Philip Molares
parent e2fbb34eed
commit c072fd657d
5 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/config/mock/security.config.mock.ts
+2 -2
View File
@@ -24,8 +24,8 @@ export function createDefaultMockSecurityConfig(): SecurityConfig {
window: 300,
},
auth: {
max: 20,
window: 600,
max: 40,
window: 900,
},
bypass: [],
},
backend/src/config/security.config.spec.ts
+6 -6
View File
@@ -18,8 +18,8 @@ describe('securityConfig: rate limiting', () => {
HD_SECURITY_RATE_LIMIT_AUTHENTICATED_WINDOW: '300',
HD_SECURITY_RATE_LIMIT_UNAUTHENTICATED_MAX: '100',
HD_SECURITY_RATE_LIMIT_UNAUTHENTICATED_WINDOW: '300',
HD_SECURITY_RATE_LIMIT_AUTH_MAX: '20',
HD_SECURITY_RATE_LIMIT_AUTH_WINDOW: '600',
HD_SECURITY_RATE_LIMIT_AUTH_MAX: '40',
HD_SECURITY_RATE_LIMIT_AUTH_WINDOW: '900',
HD_SECURITY_RATE_LIMIT_BYPASS: '127.0.0.1,::1',
/* oxlint-enable @typescript-eslint/naming-convention */
};
@@ -41,8 +41,8 @@ describe('securityConfig: rate limiting', () => {
expect(config.rateLimit.authenticated.window).toEqual(300);
expect(config.rateLimit.unauthenticated.max).toEqual(100);
expect(config.rateLimit.unauthenticated.window).toEqual(300);
expect(config.rateLimit.auth.max).toEqual(20);
expect(config.rateLimit.auth.window).toEqual(600);
expect(config.rateLimit.auth.max).toEqual(40);
expect(config.rateLimit.auth.window).toEqual(900);
expect(config.rateLimit.bypass).toEqual(['127.0.0.1', '::1']);
restore();
});
@@ -61,8 +61,8 @@ describe('securityConfig: rate limiting', () => {
expect(config.rateLimit.authenticated.window).toEqual(300);
expect(config.rateLimit.unauthenticated.max).toEqual(100);
expect(config.rateLimit.unauthenticated.window).toEqual(300);
expect(config.rateLimit.auth.max).toEqual(20);
expect(config.rateLimit.auth.window).toEqual(600);
expect(config.rateLimit.auth.max).toEqual(40);
expect(config.rateLimit.auth.window).toEqual(900);
expect(config.rateLimit.bypass).toEqual([]);
restore();
});
backend/src/config/security.config.ts
+2 -2
View File
@@ -54,12 +54,12 @@ const securityConfigSchema = z.object({
.describe('HD_SECURITY_RATE_LIMIT_UNAUTHENTICATED_WINDOW'),
}),
auth: z.object({
max: z.number().int().nonnegative().default(20).describe('HD_SECURITY_RATE_LIMIT_AUTH_MAX'),
max: z.number().int().nonnegative().default(40).describe('HD_SECURITY_RATE_LIMIT_AUTH_MAX'),
window: z
.number()
.int()
.positive()
.default(600)
.default(900)
.describe('HD_SECURITY_RATE_LIMIT_AUTH_WINDOW'),
}),
bypass: z
backend/src/security/rate-limiting.spec.ts
+3 -3
View File
@@ -24,7 +24,7 @@ describe('rate limiting', () => {
publicApi: { max: 150, window: 300 },
authenticated: { max: 600, window: 300 },
unauthenticated: { max: 100, window: 300 },
auth: { max: 20, window: 600 },
auth: { max: 40, window: 900 },
},
});
@@ -95,8 +95,8 @@ describe('rate limiting', () => {
it('uses auth limits for auth endpoints', () => {
const request = createMockedRequest({ url: '/api/private/auth/login' });
expect(getTimeWindowByRequestWithSecurityConfig(securityConfig)(request, 'key')).toBe(600000);
expect(getMaxLimitByRequestWithSecurityConfig(securityConfig)(request, 'key')).toBe(20);
expect(getTimeWindowByRequestWithSecurityConfig(securityConfig)(request, 'key')).toBe(900000);
expect(getMaxLimitByRequestWithSecurityConfig(securityConfig)(request, 'key')).toBe(40);
});
it('returns infinity when the configured max is zero', () => {
docs/content/references/config/security.md
+2 -2
View File
@@ -45,6 +45,6 @@ Setting a `*_MAX` value to `0` effectively disables rate limiting for that tier
| `HD_SECURITY_RATE_LIMIT_AUTHENTICATED_WINDOW` | 300 | Time window in seconds for authenticated usage |
| `HD_SECURITY_RATE_LIMIT_UNAUTHENTICATED_MAX` | 100 | Maximum requests for unauthenticated usage |
| `HD_SECURITY_RATE_LIMIT_UNAUTHENTICATED_WINDOW` | 300 | Time window in seconds for unauthenticated usage |
| `HD_SECURITY_RATE_LIMIT_AUTH_MAX` | 20 | Maximum of auth request attempts |
| `HD_SECURITY_RATE_LIMIT_AUTH_WINDOW` | 600 | Time window in seconds for auth request attempts |
| `HD_SECURITY_RATE_LIMIT_AUTH_MAX` | 40 | Maximum of auth request attempts |
| `HD_SECURITY_RATE_LIMIT_AUTH_WINDOW` | 900 | Time window in seconds for auth request attempts |
| `HD_SECURITY_RATE_LIMIT_BYPASS` | *none* | Bypass rate limiting for these IP addresses (comma-separated list) |