fix(addons): handle empty strings in add-on config forms [R8S-1188] (#3262)

This commit is contained in:
Steven Kang
2026-07-27 14:03:32 +12:00
committed by GitHub
parent 9f1f5599ac
commit c67a5031c8
2 changed files with 4 additions and 0 deletions
+3
View File
@@ -17,6 +17,9 @@ type InstallOptions struct {
// Values contains inline Helm values merged with the chart defaults.
// If both are provided, entries in Values override those from ValuesFile.
Values map[string]any
// ResetValues resets to chart defaults before applying Values on upgrade
// (Helm's --reset-values), so omitted keys revert rather than persist.
ResetValues bool
// ValuesFile is a path to a YAML file with Helm values to apply.
// File values are applied first; Values take precedence on conflicts.
ValuesFile string
+1
View File
@@ -190,6 +190,7 @@ func initUpgradeClient(actionConfig *action.Configuration, upgradeOpts options.I
}
upgradeClient.TakeOwnership = upgradeOpts.TakeOwnership // Equivalent to --take-ownership flag
upgradeClient.MaxHistory = upgradeOpts.MaxHistory
upgradeClient.ResetValues = upgradeOpts.ResetValues // Equivalent to --reset-values flag; off unless the caller opts in
err := configureChartPathOptions(&upgradeClient.ChartPathOptions, upgradeOpts.Version, upgradeOpts.Repo, upgradeOpts.Registry)
if err != nil {
return nil, errors.Wrap(err, "failed to configure chart path options for helm release upgrade")