fix redundant logs (#247)

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

manager/agentEventsLogs.go

@@ -45,17 +45,17 @@ func (ms *managerService) RetrieveAgentEventsLogs() {
 }
 
 func (ms *managerService) handleConnections(conn net.Conn) {
+	cmpID, err := ms.computationIDFromAddress(conn.RemoteAddr().String())
+	if err != nil {
+		ms.logger.Warn(err.Error())
+		return
+	}
 	defer conn.Close()
 	for {
 		b := make([]byte, messageSize)
 		n, err := conn.Read(b)
 		if err != nil {
 			ms.logger.Warn(err.Error())
-			cmpID, err := ms.computationIDFromAddress(conn.RemoteAddr().String())
-			if err != nil {
-				ms.logger.Warn(err.Error())
-				continue
-			}
 			go ms.reportBrokenConnection(cmpID)
 			return
 		}

manager/vm/logging.go

@@ -118,7 +118,7 @@ func (s *Stderr) Write(p []byte) (n int, err error) {
 		Message: &manager.ClientStreamMessage_AgentEvent{
 			AgentEvent: &manager.AgentEvent{
 				ComputationId: s.ComputationId,
-				EventType:     manager.VmProvision.String(),
+				EventType:     manager.VmRunning.String(),
 				Timestamp:     timestamppb.Now(),
 				Originator:    "manager",
 				Status:        manager.Error.String(),

manager/vm/logging_test.go

@@ -121,7 +121,7 @@ func TestStderrWrite(t *testing.T) {
 						agentEvent := msg.GetAgentEvent()
 						assert.NotNil(t, agentEvent)
 						assert.Equal(t, "test-computation", agentEvent.ComputationId)
-						assert.Equal(t, manager.VmProvision.String(), agentEvent.EventType)
+						assert.Equal(t, manager.VmRunning.String(), agentEvent.EventType)
 						assert.Equal(t, manager.Error.String(), agentEvent.Status)
 						assert.NotNil(t, agentEvent.Timestamp)
 					}