NOISSUE - Fix db connection leaks (#3009)

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

auth/postgres/repo.go

@@ -206,6 +206,7 @@ func (pr *patRepo) UpdateName(ctx context.Context, userID, patID, name string) (
 	if err != nil {
 		return auth.PAT{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
 	}
+	defer rows.Close()
 
 	if !rows.Next() {
 		return auth.PAT{}, repoerr.ErrNotFound
@@ -240,6 +241,7 @@ func (pr *patRepo) UpdateDescription(ctx context.Context, userID, patID, descrip
 	if err != nil {
 		return auth.PAT{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
 	}
+	defer rows.Close()
 
 	if !rows.Next() {
 		return auth.PAT{}, repoerr.ErrNotFound
@@ -275,6 +277,7 @@ func (pr *patRepo) UpdateTokenHash(ctx context.Context, userID, patID, tokenHash
 	if err != nil {
 		return auth.PAT{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
 	}
+	defer rows.Close()
 
 	if !rows.Next() {
 		return auth.PAT{}, repoerr.ErrNotFound

domains/postgres/domains.go

@@ -61,9 +61,12 @@ func (repo domainRepo) SaveDomain(ctx context.Context, d domains.Domain) (dd dom
 	if err != nil {
 		return domains.Domain{}, postgres.HandleError(repoerr.ErrCreateEntity, err)
 	}
-
 	defer row.Close()
-	row.Next()
+
+	if !row.Next() {
+		return domains.Domain{}, repoerr.ErrNotFound
+	}
+
 	dbd = dbDomain{}
 	if err := row.StructScan(&dbd); err != nil {
 		return domains.Domain{}, errors.Wrap(repoerr.ErrFailedOpDB, err)
@@ -386,6 +389,7 @@ func (repo domainRepo) UpdateDomain(ctx context.Context, id string, dr domains.D
 	var query []string
 	var upq string
 	d := domains.Domain{ID: id}
+
 	if dr.Name != nil && *dr.Name != "" {
 		query = append(query, "name = :name")
 		d.Name = *dr.Name
@@ -411,25 +415,30 @@ func (repo domainRepo) UpdateDomain(ctx context.Context, id string, dr domains.D
 		query = append(query, "updated_by = :updated_by")
 		d.UpdatedAt = *dr.UpdatedAt
 	}
+
 	if len(query) > 0 {
 		upq = strings.Join(query, ", ")
 	}
+
 	q := fmt.Sprintf(`UPDATE domains SET %s
-        WHERE id = :id
-        RETURNING id, name, tags, route, metadata, created_at, updated_at, updated_by, created_by, status;`,
-		upq)
+		WHERE id = :id
+		RETURNING id, name, tags, route, metadata, created_at, updated_at, updated_by, created_by, status;`, upq)
 
 	dbd, err := toDBDomain(d)
 	if err != nil {
 		return domains.Domain{}, errors.Wrap(repoerr.ErrUpdateEntity, err)
 	}
+
 	row, err := repo.db.NamedQueryContext(ctx, q, dbd)
 	if err != nil {
 		return domains.Domain{}, postgres.HandleError(repoerr.ErrUpdateEntity, err)
 	}
+	defer row.Close()
+
+	if !row.Next() {
+		return domains.Domain{}, repoerr.ErrNotFound
+	}
 
-	// defer row.Close()
-	row.Next()
 	dbd = dbDomain{}
 	if err := row.StructScan(&dbd); err != nil {
 		return domains.Domain{}, errors.Wrap(repoerr.ErrFailedOpDB, err)

domains/postgres/domains_test.go

@@ -593,7 +593,7 @@ func TestUpdate(t *testing.T) {
 				Metadata: &updatedMetadata,
 			},
 			response: domains.Domain{},
-			err:      repoerr.ErrFailedOpDB,
+			err:      repoerr.ErrNotFound,
 		},
 		{
 			desc:     "update domain with empty ID",
@@ -603,7 +603,7 @@ func TestUpdate(t *testing.T) {
 				Metadata: &updatedMetadata,
 			},
 			response: domains.Domain{},
-			err:      repoerr.ErrFailedOpDB,
+			err:      repoerr.ErrNotFound,
 		},
 		{
 			desc:     "update domain with malformed metadata",